Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VIEW: import #13361

Draft
wants to merge 16 commits into
base: main
Choose a base branch
from
Draft

VIEW: import #13361

wants to merge 16 commits into from
+1,785 −338

Conversation

jepett0
Copy link
Collaborator

@jepett0 jepett0 commented Jan 14, 2025

  • Export for views
  • Export style fixes
  • VIEW: import
  • YDB CLI addition of views to the export
  • Enable view import in YDB CLI

@github-actions GitHub Actions

This comment was marked as outdated.

Sign in to view
@github-actions GitHub Actions

This comment was marked as outdated.

Sign in to view
@github-actions GitHub Actions

This comment was marked as outdated.

Sign in to view
@github-actions GitHub Actions

This comment was marked as outdated.

Sign in to view
@github-actions GitHub Actions

This comment was marked as outdated.

Sign in to view
@github-actions GitHub Actions

This comment was marked as outdated.

Sign in to view
@jepett0 jepett0 requested a review from CyberROFL January 14, 2025 14:43
@jepett0 jepett0 marked this pull request as ready for review January 14, 2025 14:43
@jepett0 jepett0 requested a review from a team as a code owner January 14, 2025 14:43
@jepett0 jepett0 changed the title VIEW: import VIEW: export and import of views Jan 14, 2025
@jepett0 jepett0 marked this pull request as draft January 14, 2025 15:58
@github-actions GitHub Actions

This comment was marked as outdated.

Sign in to view
@github-actions GitHub Actions

This comment was marked as outdated.

Sign in to view
CyberROFL
CyberROFL requested changes Jan 14, 2025
View reviewed changes
ydb/core/tx/schemeshard/schemeshard_impl.cpp Outdated Show resolved Hide resolved
ydb/core/tx/schemeshard/schemeshard_private.h Outdated
Comment on lines 119 to 132
ui64 ExportId;
ui32 ItemIdx;
bool Success;
TString Error;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

А тут почему не const?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

никак не выберу на какой стул сесть:

  1. везде, где можно писать const и получить, пожалуй, слишком визуально перегруженный и к тому же сильно отличающийся по стилю от типичного для YDB код
  2. писать без const, когда value, а const добавлять только для ссылок, потому что для них эта разница действительно важна

В этом месте добавлю const, а то от соседей отличается

ydb/core/tx/schemeshard/schemeshard_schema.h Outdated Show resolved Hide resolved
ydb/core/tx/schemeshard/schemeshard_export__create.cpp Show resolved Hide resolved
ydb/core/tx/schemeshard/schemeshard_export__create.cpp Outdated Show resolved Hide resolved
ydb/core/tx/schemeshard/schemeshard_export_scheme_uploader.cpp Outdated Show resolved Hide resolved
ydb/core/tx/schemeshard/schemeshard_export_scheme_uploader.cpp Outdated Show resolved Hide resolved
@jepett0 jepett0 changed the title VIEW: export and import of views VIEW: import Jan 17, 2025
@github-actions GitHub Actions

This comment was marked as outdated.

Sign in to view
@github-actions GitHub Actions

This comment was marked as outdated.

Sign in to view
@jepett0 jepett0 mentioned this pull request Jan 22, 2025
Open
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 22, 2025 •
edited
Loading

⚪ 2025-01-22 10:36:29 UTC Pre-commit check linux-x86_64-release-asan for 8a4ba7b has started.
⚪ 2025-01-22 10:36:42 UTC Artifacts will be uploaded here
⚪ 2025-01-22 10:40:01 UTC ya make is running...
🟡 2025-01-22 12:19:01 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
13491 13416 0 21 29 25

⚪ 2025-01-22 12:20:21 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-01-22 12:32:20 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
104 (only retried tests) 70 0 6 3 25

⚪ 2025-01-22 12:32:29 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-01-22 12:45:21 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
57 (only retried tests) 27 0 5 2 23

🟢 2025-01-22 12:45:35 UTC Build successful.
🔴 2025-01-22 12:46:06 UTC ydbd size 3.6 GiB changed* by +3.4 MiB, which is >= 2.0 MiB vs main: Alert

ydbd size dash main: aa7a166 merge: 8a4ba7b diff diff %
ydbd size 3 856 031 536 Bytes 3 859 552 104 Bytes +3.4 MiB +0.091%
ydbd stripped size 1 348 618 352 Bytes 1 349 805 712 Bytes +1.1 MiB +0.088%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 22, 2025 •
edited
Loading

⚪ 2025-01-22 10:37:16 UTC Pre-commit check linux-x86_64-relwithdebinfo for 8a4ba7b has started.
⚪ 2025-01-22 10:37:29 UTC Artifacts will be uploaded here
⚪ 2025-01-22 10:40:49 UTC ya make is running...
🟡 2025-01-22 12:07:16 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
27936 25347 0 14 2441 134

⚪ 2025-01-22 12:09:37 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-01-22 12:23:27 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
251 (only retried tests) 131 0 2 0 118

⚪ 2025-01-22 12:23:36 UTC ya make is running... (failed tests rerun, try 3)
🟢 2025-01-22 12:35:41 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
174 (only retried tests) 57 0 0 0 117

🟢 2025-01-22 12:35:52 UTC Build successful.
🟡 2025-01-22 12:36:17 UTC ydbd size 2.1 GiB changed* by +2.0 MiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: aa7a166 merge: 8a4ba7b diff diff %
ydbd size 2 219 415 328 Bytes 2 221 465 216 Bytes +2.0 MiB +0.092%
ydbd stripped size 469 474 576 Bytes 469 796 624 Bytes +314.5 KiB +0.069%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CyberROFL CyberROFL CyberROFL requested changes

Requested changes must be addressed to merge this pull request.

Assignees

@jepett0 jepett0

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jepett0 @CyberROFL